Skip to content

Fix null ref type warning in Nuke #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

Fix null ref type warning in Nuke #7382

merged 1 commit into from
Aug 14, 2025

Conversation

andrewlock
Copy link
Member

Summary of changes

Fix a warning when running Nuke

Reason for change

I introduced a null reference type. And the compiler is upset about it.

Implementation details

Remove the offending ?

Test coverage

Tested it locally

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 12, 2025
@andrewlock andrewlock requested a review from a team as a code owner August 12, 2025 16:51
@pr-commenter
Copy link

pr-commenter bot commented Aug 12, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7382 compared to master:

  • All benchmarks have the same speed
  • 7 benchmarks have fewer allocations
  • 7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.03 KB 6.09 KB 59 B 0.98%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.68 KB 5.72 KB 41 B 0.72%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.5μs 57.7ns 331ns 0 0 0 5.49 KB
master StartStopWithChild netcoreapp3.1 14.2μs 57.1ns 206ns 0 0 0 5.68 KB
master StartStopWithChild net472 21.7μs 121ns 734ns 0.987 0.329 0.11 6.03 KB
#7382 StartStopWithChild net6.0 10.3μs 58.2ns 386ns 0 0 0 5.5 KB
#7382 StartStopWithChild netcoreapp3.1 13.8μs 34.2ns 133ns 0 0 0 5.72 KB
#7382 StartStopWithChild net472 22.4μs 127ns 874ns 0.89 0.222 0 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.35 KB 3.31 KB -46 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 932μs 103ns 355ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 67.4ns 261ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 92.5ns 358ns 0 0 0 3.35 KB
#7382 WriteAndFlushEnrichedTraces net6.0 940μs 98.7ns 356ns 0 0 0 2.71 KB
#7382 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 62.7ns 226ns 0 0 0 2.7 KB
#7382 WriteAndFlushEnrichedTraces net472 1.19ms 321ns 1.24μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 324μs 1.72μs 8.94μs 0 0 0 179.42 KB
master AllCycleSimpleBody netcoreapp3.1 478μs 1.52μs 5.46μs 0 0 0 183.24 KB
master AllCycleSimpleBody net472 424μs 112ns 420ns 33.3 2.08 0 209.98 KB
master AllCycleMoreComplexBody net6.0 340μs 619ns 2.4μs 0 0 0 182.92 KB
master AllCycleMoreComplexBody netcoreapp3.1 479μs 1.38μs 5.35μs 0 0 0 186.66 KB
master AllCycleMoreComplexBody net472 432μs 175ns 679ns 32.3 0 0 213.49 KB
master ObjectExtractorSimpleBody net6.0 328ns 1.74ns 8.5ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 399ns 1.22ns 4.71ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 314ns 0.951ns 3.68ns 0.0432 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.4μs 32.1ns 147ns 0 0 0 3.79 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 8.3μs 29.7ns 115ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.71μs 1.44ns 5.39ns 0.571 0 0 3.8 KB
#7382 AllCycleSimpleBody net6.0 330μs 198ns 766ns 0 0 0 179.42 KB
#7382 AllCycleSimpleBody netcoreapp3.1 472μs 1.84μs 6.87μs 0 0 0 183.24 KB
#7382 AllCycleSimpleBody net472 423μs 44.6ns 167ns 33.3 2.08 0 209.98 KB
#7382 AllCycleMoreComplexBody net6.0 336μs 114ns 440ns 0 0 0 182.92 KB
#7382 AllCycleMoreComplexBody netcoreapp3.1 504μs 288ns 1.11μs 0 0 0 186.66 KB
#7382 AllCycleMoreComplexBody net472 437μs 168ns 649ns 32.3 0 0 213.49 KB
#7382 ObjectExtractorSimpleBody net6.0 316ns 1.74ns 10.6ns 0 0 0 280 B
#7382 ObjectExtractorSimpleBody netcoreapp3.1 400ns 1.97ns 8.37ns 0 0 0 272 B
#7382 ObjectExtractorSimpleBody net472 307ns 0.021ns 0.0813ns 0.0434 0 0 281 B
#7382 ObjectExtractorMoreComplexBody net6.0 6.4μs 2.95ns 10.6ns 0 0 0 3.78 KB
#7382 ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 38.3ns 153ns 0 0 0 3.69 KB
#7382 ObjectExtractorMoreComplexBody net472 6.73μs 1.86ns 6.71ns 0.57 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.4μs 209ns 810ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.1μs 126ns 488ns 0 0 0 32.4 KB
master EncodeArgs net472 114μs 210ns 812ns 4.6 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 49.5ns 179ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 200μs 144ns 560ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 264μs 57.8ns 216ns 0 0 0 2.16 KB
#7382 EncodeArgs net6.0 76μs 233ns 904ns 0 0 0 32.4 KB
#7382 EncodeArgs netcoreapp3.1 97.8μs 122ns 474ns 0 0 0 32.4 KB
#7382 EncodeArgs net472 111μs 13.1ns 49.2ns 4.99 0 0 32.51 KB
#7382 EncodeLegacyArgs net6.0 145μs 65.4ns 253ns 0 0 0 2.14 KB
#7382 EncodeLegacyArgs netcoreapp3.1 196μs 134ns 483ns 0 0 0 2.14 KB
#7382 EncodeLegacyArgs net472 262μs 29.1ns 105ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 396μs 84.6ns 328ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 821μs 10.7μs 106μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 434μs 125ns 483ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 291μs 126ns 490ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 304μs 66.7ns 241ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 314μs 35.3ns 137ns 0 0 0 2.29 KB
#7382 RunWafRealisticBenchmark net6.0 398μs 72.8ns 282ns 0 0 0 4.55 KB
#7382 RunWafRealisticBenchmark netcoreapp3.1 773μs 15.7μs 157μs 0 0 0 4.48 KB
#7382 RunWafRealisticBenchmark net472 431μs 75ns 291ns 0 0 0 4.66 KB
#7382 RunWafRealisticBenchmarkWithAttack net6.0 289μs 105ns 407ns 0 0 0 2.24 KB
#7382 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 193ns 670ns 0 0 0 2.22 KB
#7382 RunWafRealisticBenchmarkWithAttack net472 314μs 75.5ns 293ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 62.1μs 79.1ns 306ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.2μs 93.9ns 325ns 0 0 0 17.42 KB
master SendRequest net472 0.011ns 0.00208ns 0.00805ns 0 0 0 0 b
#7382 SendRequest net6.0 60.7μs 59.2ns 229ns 0 0 0 14.52 KB
#7382 SendRequest netcoreapp3.1 71μs 43.3ns 168ns 0 0 0 17.42 KB
#7382 SendRequest net472 0.00775ns 0.00154ns 0.00595ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 6 B 7 B 1 B 16.67%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 49 B 2 B 4.26%

Fewer allocations 🎉 in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 3 B -1 B -25.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.9ms 7.69μs 29.8μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.13ms 4.49μs 16.8μs 0 0 0 640 KB
master OriginalCharSlice net472 2.69ms 280ns 1.01μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.4ms 298ns 1.15μs 0 0 0 6 B
master OptimizedCharSlice netcoreapp3.1 1.68ms 149ns 576ns 0 0 0 1 B
master OptimizedCharSlice net472 1.98ms 388ns 1.5μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 839μs 41ns 159ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 837μs 66.2ns 256ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 51.9ns 201ns 0 0 0 47 B
#7382 OriginalCharSlice net6.0 1.97ms 3.83μs 14.3μs 0 0 0 640 KB
#7382 OriginalCharSlice netcoreapp3.1 2.1ms 3.91μs 14.6μs 0 0 0 640 KB
#7382 OriginalCharSlice net472 2.64ms 122ns 455ns 100 0 0 641.95 KB
#7382 OptimizedCharSlice net6.0 1.36ms 111ns 416ns 0 0 0 7 B
#7382 OptimizedCharSlice netcoreapp3.1 1.64ms 163ns 609ns 0 0 0 1 B
#7382 OptimizedCharSlice net472 2.03ms 353ns 1.37μs 0 0 0 73 B
#7382 OptimizedCharSliceWithPool net6.0 867μs 38.7ns 150ns 0 0 0 3 B
#7382 OptimizedCharSliceWithPool netcoreapp3.1 852μs 32.3ns 125ns 0 0 0 0 b
#7382 OptimizedCharSliceWithPool net472 1.16ms 62.3ns 241ns 0 0 0 49 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.68 KB 42.64 KB 962 B 2.31%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.05 KB 42.52 KB 462 B 1.10%

Fewer allocations 🎉 in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.02 KB 55.73 KB -283 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 681μs 2.49μs 9.66μs 0 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 688μs 982ns 3.8μs 0 0 0 42.05 KB
master WriteAndFlushEnrichedTraces net472 978μs 2.32μs 8.67μs 4.46 0 0 56.02 KB
#7382 WriteAndFlushEnrichedTraces net6.0 720μs 7.31μs 68.9μs 0 0 0 42.64 KB
#7382 WriteAndFlushEnrichedTraces netcoreapp3.1 677μs 3.84μs 25.8μs 0 0 0 42.52 KB
#7382 WriteAndFlushEnrichedTraces net472 1.05ms 6.01μs 46.5μs 4.46 0 0 55.73 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 2μs 1.23ns 4.61ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.71μs 8.49ns 32.9ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.92μs 2.33ns 9.02ns 0.145 0.0145 0 987 B
#7382 ExecuteNonQuery net6.0 1.99μs 2.82ns 10.5ns 0 0 0 1.02 KB
#7382 ExecuteNonQuery netcoreapp3.1 2.6μs 7.42ns 28.7ns 0 0 0 1.02 KB
#7382 ExecuteNonQuery net472 2.82μs 3.42ns 13.2ns 0.154 0.014 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.7μs 7.92ns 30.7ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.27μs 8.65ns 32.4ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.56μs 1.41ns 5.29ns 0.159 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.78μs 8.74ns 37.1ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.49μs 6.66ns 25.8ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.73μs 1.97ns 7.63ns 0.169 0 0 1.1 KB
#7382 CallElasticsearch net6.0 1.75μs 1.73ns 6.71ns 0 0 0 1.03 KB
#7382 CallElasticsearch netcoreapp3.1 2.29μs 10.1ns 37.9ns 0 0 0 1.03 KB
#7382 CallElasticsearch net472 3.55μs 0.903ns 3.5ns 0.159 0 0 1.04 KB
#7382 CallElasticsearchAsync net6.0 1.85μs 7.42ns 28.7ns 0 0 0 1.01 KB
#7382 CallElasticsearchAsync netcoreapp3.1 2.39μs 1.73ns 6.72ns 0 0 0 1.08 KB
#7382 CallElasticsearchAsync net472 3.56μs 1.42ns 5.5ns 0.161 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.8μs 1.67ns 6.47ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.38μs 11.5ns 50.2ns 0 0 0 952 B
master ExecuteAsync net472 2.53μs 3.08ns 11.9ns 0.14 0 0 915 B
#7382 ExecuteAsync net6.0 1.94μs 9.61ns 39.6ns 0 0 0 952 B
#7382 ExecuteAsync netcoreapp3.1 2.31μs 9.23ns 35.8ns 0 0 0 952 B
#7382 ExecuteAsync net472 2.5μs 1.93ns 7.46ns 0.139 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.85μs 8.6ns 33.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.35μs 28.3ns 110ns 0 0 0 2.9 KB
master SendAsync net472 12.6μs 12.9ns 50.1ns 0.503 0 0 3.18 KB
#7382 SendAsync net6.0 6.93μs 8.69ns 31.3ns 0 0 0 2.36 KB
#7382 SendAsync netcoreapp3.1 8.66μs 18.7ns 70ns 0 0 0 2.9 KB
#7382 SendAsync net472 12.2μs 11.4ns 44.1ns 0.487 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 254.85 KB 272.23 KB 17.38 KB 6.82%

Fewer allocations 🎉 in #7382

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.78 KB 43.1 KB -672 B -1.54%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 257.62 KB 249.86 KB -7.77 KB -3.02%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 287.58 KB 278.53 KB -9.05 KB -3.15%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 48.2μs 270ns 1.71μs 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 55.1μs 751ns 7.47μs 0 0 0 43.15 KB
master StringConcatBenchmark net472 58.7μs 137ns 496ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 459μs 1.82μs 6.58μs 0 0 0 257.62 KB
master StringConcatAspectBenchmark netcoreapp3.1 483μs 1.85μs 6.68μs 0 0 0 254.85 KB
master StringConcatAspectBenchmark net472 404μs 1.84μs 9.22μs 0 0 0 287.58 KB
#7382 StringConcatBenchmark net6.0 50.8μs 765ns 7.57μs 0 0 0 43.1 KB
#7382 StringConcatBenchmark netcoreapp3.1 56.6μs 951ns 9.51μs 0 0 0 43.32 KB
#7382 StringConcatBenchmark net472 57.1μs 104ns 375ns 0 0 0 57.34 KB
#7382 StringConcatAspectBenchmark net6.0 443μs 2.34μs 11.2μs 0 0 0 249.86 KB
#7382 StringConcatAspectBenchmark netcoreapp3.1 512μs 2.36μs 8.81μs 0 0 0 272.23 KB
#7382 StringConcatAspectBenchmark net472 402μs 2.31μs 17.8μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.53μs 13.2ns 59.2ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.37μs 13.9ns 54ns 0 0 0 1.7 KB
master EnrichedLog net472 3.94μs 5.49ns 21.3ns 0.257 0 0 1.64 KB
#7382 EnrichedLog net6.0 2.51μs 13.3ns 68ns 0 0 0 1.7 KB
#7382 EnrichedLog netcoreapp3.1 3.46μs 16.5ns 66ns 0 0 0 1.7 KB
#7382 EnrichedLog net472 3.8μs 2.85ns 11ns 0.245 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 119ns 462ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 68.9ns 258ns 0 0 0 4.31 KB
master EnrichedLog net472 168μs 101ns 390ns 0 0 0 4.52 KB
#7382 EnrichedLog net6.0 122μs 31.6ns 110ns 0 0 0 4.31 KB
#7382 EnrichedLog netcoreapp3.1 127μs 235ns 880ns 0 0 0 4.31 KB
#7382 EnrichedLog net472 168μs 166ns 622ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.93μs 7.71ns 28.9ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.57μs 17.5ns 67.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.45μs 6.72ns 26ns 0.297 0 0 2.08 KB
#7382 EnrichedLog net6.0 4.91μs 2.83ns 10.9ns 0 0 0 2.26 KB
#7382 EnrichedLog netcoreapp3.1 6.8μs 4.95ns 18.5ns 0 0 0 2.26 KB
#7382 EnrichedLog net472 7.44μs 3.93ns 14.7ns 0.297 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.05μs 9.2ns 35.6ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.62μs 9.75ns 36.5ns 0 0 0 1.2 KB
master SendReceive net472 3.14μs 2.47ns 9.58ns 0.189 0 0 1.2 KB
#7382 SendReceive net6.0 1.99μs 9.99ns 42.4ns 0 0 0 1.2 KB
#7382 SendReceive netcoreapp3.1 2.49μs 1.77ns 6.85ns 0 0 0 1.2 KB
#7382 SendReceive net472 3.24μs 3.89ns 14.5ns 0.19 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.2μs 7.17ns 26.8ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.64μs 16ns 61.9ns 0 0 0 1.63 KB
master EnrichedLog net472 6.77μs 5.73ns 22.2ns 0.303 0 0 2.03 KB
#7382 EnrichedLog net6.0 4.08μs 1.31ns 4.53ns 0 0 0 1.58 KB
#7382 EnrichedLog netcoreapp3.1 5.64μs 10.5ns 40.6ns 0 0 0 1.63 KB
#7382 EnrichedLog net472 6.63μs 5.04ns 19.5ns 0.296 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 737ns 3.89ns 20.6ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 929ns 4.85ns 25.7ns 0 0 0 576 B
master StartFinishSpan net472 929ns 0.903ns 3.5ns 0.0888 0 0 578 B
master StartFinishScope net6.0 901ns 4.31ns 17.2ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.17μs 6.39ns 34.4ns 0 0 0 696 B
master StartFinishScope net472 1.12μs 0.669ns 2.59ns 0.102 0 0 658 B
#7382 StartFinishSpan net6.0 760ns 3.73ns 15.8ns 0 0 0 576 B
#7382 StartFinishSpan netcoreapp3.1 960ns 4.73ns 21.7ns 0 0 0 576 B
#7382 StartFinishSpan net472 920ns 0.0545ns 0.204ns 0.0876 0 0 578 B
#7382 StartFinishScope net6.0 929ns 4.79ns 21.4ns 0 0 0 696 B
#7382 StartFinishScope netcoreapp3.1 1.2μs 6.51ns 35.1ns 0 0 0 696 B
#7382 StartFinishScope net472 1.09μs 0.168ns 0.629ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 0.615ns 2.3ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.41μs 6.88ns 27.5ns 0 0 0 696 B
master RunOnMethodBegin net472 1.42μs 0.845ns 3.27ns 0.0996 0 0 658 B
#7382 RunOnMethodBegin net6.0 1.05μs 5.6ns 28ns 0 0 0 696 B
#7382 RunOnMethodBegin netcoreapp3.1 1.39μs 6.66ns 27.5ns 0 0 0 696 B
#7382 RunOnMethodBegin net472 1.44μs 2.44ns 9.44ns 0.101 0 0 658 B

@andrewlock andrewlock merged commit 376e9d1 into master Aug 14, 2025
67 of 69 checks passed
@andrewlock andrewlock deleted the andrew/ci/fix-nuke-warnings branch August 14, 2025 07:22
@github-actions github-actions bot added this to the vNext-v3 milestone Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes

@bouwkast bouwkast bouwkast approved these changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
3.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewlock @lucaspimentel @bouwkast @zacharycmontoya